From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Use the new vm [un]bind functions Date: Fri, 20 Sep 2013 23:22:52 +0200 Message-ID: <20130920212251.GL32145@phenom.ffwll.local> References: <1379601919-22742-1-git-send-email-benjamin.widawsky@intel.com> <1379649999-16923-1-git-send-email-benjamin.widawsky@intel.com> <20130920104348.GD24200@nuc-i3427.alporthouse.com> <20130920204422.GB22399@bwidawsk.net> <20130920205551.GA16830@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f52.google.com (mail-ee0-f52.google.com [74.125.83.52]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F122E5DC4 for ; Fri, 20 Sep 2013 14:22:37 -0700 (PDT) Received: by mail-ee0-f52.google.com with SMTP id c41so523454eek.11 for ; Fri, 20 Sep 2013 14:22:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130920205551.GA16830@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Ben Widawsky , Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Fri, Sep 20, 2013 at 09:55:51PM +0100, Chris Wilson wrote: > On Fri, Sep 20, 2013 at 01:44:23PM -0700, Ben Widawsky wrote: > > Furthermore, the actually pinning (pin count increment) should be > > unnecessary, but I assume you were just trying to save me some typing. > > Yes, the pin-count adjustments should be unnecessary - but not a huge > burden, and I was thinking it may help in the future as we may want to > explicitly hold the pin until move-to-active for all objects. That > future being where we strive to reduce hold times on struct_mutex. My grand plan is that pinning-to-mark-an-object-reserved-for-execbuf will be replaced by per-object-lock-acquired. By using the owner-tracking of ww mutexes we'll even get a "you have this already acquired" notice for free. And then we obviously need to hold the ww mutex lock until we're done updating the state, so past the move-to-active. But I haven't worked out a concrete plan for how to get there yet, so dunno whether sprinkling more pinnning around is a good idea or not. Just wanted to drop my 2 uninformed cents here ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch