From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Do not unlock upon error in i915_gem_idle()
Date: Sat, 21 Sep 2013 00:40:19 +0200 [thread overview]
Message-ID: <20130920224019.GU32145@phenom.ffwll.local> (raw)
In-Reply-To: <1379113024-1033-1-git-send-email-chris@chris-wilson.co.uk>
On Fri, Sep 13, 2013 at 11:57:04PM +0100, Chris Wilson wrote:
> We never took the lock ourselves and all callers expect the struct_mutex
> to be locked upon return (be it success or error), thereore dropping the
> lock along the error paths looks to be a vestigial error from
>
> commit db1b76ca6a79c774074ae87bee7afc0825a478f5
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Tue Jul 9 16:51:37 2013 +0200
>
> drm/i915: don't frob mm.suspended when not using ums
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-09-20 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 22:57 [PATCH] drm/i915: Do not unlock upon error in i915_gem_idle() Chris Wilson
2013-09-20 22:40 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920224019.GU32145@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox