From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Do not unlock upon error in i915_gem_idle() Date: Sat, 21 Sep 2013 00:40:19 +0200 Message-ID: <20130920224019.GU32145@phenom.ffwll.local> References: <1379113024-1033-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46]) by gabe.freedesktop.org (Postfix) with ESMTP id CDC82E5F9C for ; Fri, 20 Sep 2013 15:40:04 -0700 (PDT) Received: by mail-ee0-f46.google.com with SMTP id c13so547663eek.33 for ; Fri, 20 Sep 2013 15:40:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1379113024-1033-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Sep 13, 2013 at 11:57:04PM +0100, Chris Wilson wrote: > We never took the lock ourselves and all callers expect the struct_mutex > to be locked upon return (be it success or error), thereore dropping the > lock along the error paths looks to be a vestigial error from > > commit db1b76ca6a79c774074ae87bee7afc0825a478f5 > Author: Daniel Vetter > Date: Tue Jul 9 16:51:37 2013 +0200 > > drm/i915: don't frob mm.suspended when not using ums > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch