From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Rip out SUPPORTS_EDP Date: Tue, 24 Sep 2013 11:00:38 +0200 Message-ID: <20130924090018.GA13668@phenom.ffwll.local> References: <1379767002-16299-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id AE807E5EBC for ; Tue, 24 Sep 2013 02:00:25 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id b47so2315903eek.17 for ; Tue, 24 Sep 2013 02:00:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Daniel Vetter , Intel Graphics Development , Paulo Zanoni , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Mon, Sep 23, 2013 at 02:04:43PM -0300, Paulo Zanoni wrote: > 2013/9/21 Daniel Vetter : > > It only controls the setting of the vbt.edp_support variable, which in > > turn only controls one debug output plus can also force-disable the > > lvds output. > > > > Since the value only restricted this logic to mobile ilk there's the > > slight risk that this will break lvds on desktop ilk or on snb/ivb > > platforms. But with the vbt it's better when we know what's going on > > here, so let's rip it out and see what happens. > > I think this is a little bit too risky, but the patch does what it > says in the box and also mentions the risk... I was going to give a > Reviewed-by tag and leave the merge-or-not-merge question to the > maintainer, but I noticed the patch is already even merged (by > accident?). I was lazy and didn't create a seperate branch for it ;-) Can I still smash your r-b on top? > Are we aware of any real-world machines with eDP + LVDS? I haven't seen any of those. What has been observed in the wild is lvds + sdvo lvds, but I've never seen edp + some other panel anywhere ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch