From: Daniel Vetter <daniel@ffwll.ch>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Meelis Roos" <mroos@ut.ee>
Subject: Re: [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf
Date: Tue, 24 Sep 2013 11:05:57 +0200 [thread overview]
Message-ID: <20130924090557.GC13668@phenom.ffwll.local> (raw)
In-Reply-To: <20130923095535.GD8482@nuc-i3427.alporthouse.com>
On Mon, Sep 23, 2013 at 10:55:35AM +0100, Chris Wilson wrote:
> On Mon, Sep 23, 2013 at 10:37:02AM +0200, Daniel Vetter wrote:
> > On Mon, Sep 23, 2013 at 10:17 AM, Ville Syrjälä
> > <ville.syrjala@linux.intel.com> wrote:
> > > Hmm. Why not just this?
> > >
> > > pipeconf = 0;
> > > if (pipe == PIPE_A && QUIRK)
> > > pipeconf |= PIPECONF_ENABLE;
> >
> > After resume the bios might or might not have enabled pipe A already.
> > We have a bit of magic to make sure that on resume we set up a decent
> > mode for pipe A, but I fear if I just smash pipe A to always on we'd
> > enable it in a bogus state and hang the hw. Hence the readback.
>
> Yet, the
>
> if (A)
> pipeconf = READ() & MAGIC;
> else
> pipeconf = 0;
> if (B)
> pipeconf = READ() & MAGIC2;
I don't see that 2nd READ() you're seeing ... Where is it?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-09-24 9:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 18:51 [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf Daniel Vetter
2013-09-23 8:17 ` Ville Syrjälä
2013-09-23 8:37 ` Daniel Vetter
2013-09-23 9:55 ` Chris Wilson
2013-09-23 21:18 ` Meelis Roos
2013-09-23 21:19 ` Chris Wilson
2013-09-24 9:05 ` Daniel Vetter [this message]
2013-09-24 9:11 ` Chris Wilson
2013-09-23 12:06 ` Meelis Roos
2013-09-23 20:05 ` Meelis Roos
2013-09-23 20:11 ` Chris Wilson
2013-09-24 9:46 ` Daniel Vetter
2013-09-24 12:05 ` Chris Wilson
2013-09-24 12:50 ` Daniel Vetter
2013-09-23 15:15 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924090557.GC13668@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mroos@ut.ee \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox