From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: preserve pipe A quirk in
 i9xx_set_pipeconf
Date: Tue, 24 Sep 2013 11:05:57 +0200
Message-ID: <20130924090557.GC13668@phenom.ffwll.local>
References: <1379875872-16674-1-git-send-email-daniel.vetter@ffwll.ch>
	<20130923081733.GS4531@intel.com>
	<CAKMK7uHObhC3ixQHzvheTOwcLbomQ-Zyff7ix+ZD8ZOP3Lt=MQ@mail.gmail.com>
	<20130923095535.GD8482@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50])
	by gabe.freedesktop.org (Postfix) with ESMTP id 43731E7496
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Sep 2013 02:05:41 -0700 (PDT)
Received: by mail-ee0-f50.google.com with SMTP id d51so2332367eek.9
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Sep 2013 02:05:40 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130923095535.GD8482@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel.vetter@ffwll.ch>, Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Meelis Roos <mroos@ut.ee>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Sep 23, 2013 at 10:55:35AM +0100, Chris Wilson wrote:
> On Mon, Sep 23, 2013 at 10:37:02AM +0200, Daniel Vetter wrote:
> > On Mon, Sep 23, 2013 at 10:17 AM, Ville Syrj=E4l=E4
> > <ville.syrjala@linux.intel.com> wrote:
> > > Hmm. Why not just this?
> > >
> > > pipeconf =3D 0;
> > > if (pipe =3D=3D PIPE_A && QUIRK)
> > >  pipeconf |=3D PIPECONF_ENABLE;
> > =

> > After resume the bios might or might not have enabled pipe A already.
> > We have a bit of magic to make sure that on resume we set up a decent
> > mode for pipe A, but I fear if I just smash pipe A to always on we'd
> > enable it in a bogus state and hang the hw. Hence the readback.
> =

> Yet, the
> =

> if (A)
>   pipeconf =3D READ() & MAGIC;
> else
>   pipeconf =3D 0;
> if (B)
>   pipeconf =3D READ() & MAGIC2;

I don't see that 2nd READ() you're seeing ... Where is it?
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch