From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix intel_crtc_mode_get() mode clock Date: Tue, 24 Sep 2013 11:13:37 +0200 Message-ID: <20130924091337.GF13668@phenom.ffwll.local> References: <1379947700-1242-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 70448E5C75 for ; Tue, 24 Sep 2013 02:13:21 -0700 (PDT) Received: by mail-ee0-f41.google.com with SMTP id d17so2345193eek.0 for ; Tue, 24 Sep 2013 02:13:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1379947700-1242-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Sep 23, 2013 at 05:48:20PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > i9xx_crtc_clock_get() no longer populates adjusted_mode.clock, so we > must get the pixel clock from port_clock in intel_crtc_mode_get(). > = > This bug caused Chris's 845g machine to lockup during boot, and it > was introduced in: > = > commit 18442d08786472c63a0a80c27f92b033dffc26de > Author: Ville Syrj=E4l=E4 > Date: Fri Sep 13 16:00:08 2013 +0300 > = > drm/i915: Fix port_clock and adjusted_mode.clock readout all over > = > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D69713 > Tested-by: Chris Wilson > Signed-off-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch