From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 00/13] drm-intel-collector - review request
Date: Tue, 24 Sep 2013 13:22:13 +0200
Message-ID: <20130924112213.GQ13668@phenom.ffwll.local>
References: <1379968410-14428-1-git-send-email-rodrigo.vivi@gmail.com>
	<20130924101519.GJ13668@phenom.ffwll.local>
	<20130924103203.GC10644@nuc-i3427.alporthouse.com>
	<CAKMK7uEBC0TK9gs1TDe3zZPeic8spBR65cETEr=kdUfnf=6A7g@mail.gmail.com>
	<20130924111127.GD10644@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com
	[209.85.215.181])
	by gabe.freedesktop.org (Postfix) with ESMTP id 599EFE7594
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Sep 2013 04:21:56 -0700 (PDT)
Received: by mail-ea0-f181.google.com with SMTP id d10so2375608eaj.26
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Sep 2013 04:21:55 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130924111127.GD10644@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>, Rodrigo Vivi <rodrigo.vivi@gmail.com>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Sep 24, 2013 at 12:11:27PM +0100, Chris Wilson wrote:
> On Tue, Sep 24, 2013 at 12:47:07PM +0200, Daniel Vetter wrote:
> > The idea that was floated was to use the reg/unreg functions of
> > DEFINE_TRACE_FN to do the irq get/put dance. The problem seems to be
> > that doing fancy stuff from within the tracepoint itself isn't awesome
> > for -rt locking. So we don't enable the interrupts when we don't need
> > them, but only when the tracepoint is active.
> 
> And besides the complaint was about trace_irq_seqno, was it not?

It's the ->get_irq call hidden in i915_trace_irq_get within a
TP_fast_assign clause. The racy business around accessing
ring->trace_irq_seqno is a bit orthogonal I think.

> > The slight problem is that I don't see any users of this stuff, so I
> > think we can still go meh.
> 
> Indeed, I do not know how to do what he wants under the confines of the
> current tracepoint API.

Hm, maybe I need to yell at him again.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch