From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: preserve pipe A quirk in
	i9xx_set_pipeconf
Date: Tue, 24 Sep 2013 14:50:59 +0200
Message-ID: <20130924125059.GS13668@phenom.ffwll.local>
References: <20130923201106.GA10644@nuc-i3427.alporthouse.com>
	<1380015974-31332-1-git-send-email-daniel.vetter@ffwll.ch>
	<20130924120507.GF10644@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 98618E7140
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Sep 2013 05:50:42 -0700 (PDT)
Received: by mail-ee0-f49.google.com with SMTP id d41so2417442eek.22
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Sep 2013 05:50:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130924120507.GF10644@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Meelis Roos <mroos@ut.ee>, Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Sep 24, 2013 at 01:05:07PM +0100, Chris Wilson wrote:
> On Tue, Sep 24, 2013 at 11:46:14AM +0200, Daniel Vetter wrote:
> > This regression has been introduced in
> > =

> > commit 9f11a9e4e50006b615ba94722dfc33ced89664cf
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Thu Jun 13 00:54:58 2013 +0200
> > =

> >     drm/i915: set up PIPECONF explicitly for i9xx/vlv platforms
> > =

> > Ville brough up the idea that this is just the pipe A quirk gone
> > wrong.
> > =

> > Note that after resume the bios might or might not have enabled pipe A
> > already.  We have a bit of magic to make sure that on resume we set up
> > a decent mode for pipe A, but I fear if I just smash pipe A to always
> > on we'd enable it in a bogus state and hang the hw. Hence the
> > readback.
> > =

> > v2: Clarify the logic a bit as suggested by Chris. Also amend the
> > commit message to clarify why we don't unconditionally enable the
> > pipe.
> > =

> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D66462
> > References: https://lkml.org/lkml/2013/8/26/238
> > Cc: Meelis Roos <mroos@ut.ee>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> =

> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> =

> would still prefer pipeconf |=3D PIPECONF_ENABLE though.

Yeah, makes sense. Fixed and applied, thanks for the review.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch