From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: backlight combination mode bit is gen4 only Date: Tue, 24 Sep 2013 17:41:21 +0300 Message-ID: <20130924144121.GD4531@intel.com> References: <1380030279-9745-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B857E6CA4 for ; Tue, 24 Sep 2013 07:41:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1380030279-9745-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 24, 2013 at 04:44:39PM +0300, Jani Nikula wrote: > Not valid for later non-PCH split platforms such as VLV. > = > Signed-off-by: Jani Nikula The bit is mbz on VLV, so I guess it should be 0, but better safe than sorry, and it gets rid of a useless register read. Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/in= tel_panel.c > index 3bc89a6..8f025c6 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -329,7 +329,7 @@ static int is_backlight_combination_mode(struct drm_d= evice *dev) > { > struct drm_i915_private *dev_priv =3D dev->dev_private; > = > - if (INTEL_INFO(dev)->gen >=3D 4) > + if (IS_GEN4(dev)) > return I915_READ(BLC_PWM_CTL2) & BLM_COMBINATION_MODE; > = > if (IS_GEN2(dev)) > -- = > 1.7.10.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC