* [PATCH] drm/i915: backlight combination mode bit is gen4 only
@ 2013-09-24 13:44 Jani Nikula
2013-09-24 14:41 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2013-09-24 13:44 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Not valid for later non-PCH split platforms such as VLV.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index 3bc89a6..8f025c6 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -329,7 +329,7 @@ static int is_backlight_combination_mode(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = dev->dev_private;
- if (INTEL_INFO(dev)->gen >= 4)
+ if (IS_GEN4(dev))
return I915_READ(BLC_PWM_CTL2) & BLM_COMBINATION_MODE;
if (IS_GEN2(dev))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: backlight combination mode bit is gen4 only
2013-09-24 13:44 [PATCH] drm/i915: backlight combination mode bit is gen4 only Jani Nikula
@ 2013-09-24 14:41 ` Ville Syrjälä
2013-09-24 15:04 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjälä @ 2013-09-24 14:41 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Tue, Sep 24, 2013 at 04:44:39PM +0300, Jani Nikula wrote:
> Not valid for later non-PCH split platforms such as VLV.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
The bit is mbz on VLV, so I guess it should be 0, but better safe than
sorry, and it gets rid of a useless register read.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index 3bc89a6..8f025c6 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -329,7 +329,7 @@ static int is_backlight_combination_mode(struct drm_device *dev)
> {
> struct drm_i915_private *dev_priv = dev->dev_private;
>
> - if (INTEL_INFO(dev)->gen >= 4)
> + if (IS_GEN4(dev))
> return I915_READ(BLC_PWM_CTL2) & BLM_COMBINATION_MODE;
>
> if (IS_GEN2(dev))
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: backlight combination mode bit is gen4 only
2013-09-24 14:41 ` Ville Syrjälä
@ 2013-09-24 15:04 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2013-09-24 15:04 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx
On Tue, Sep 24, 2013 at 05:41:21PM +0300, Ville Syrjälä wrote:
> On Tue, Sep 24, 2013 at 04:44:39PM +0300, Jani Nikula wrote:
> > Not valid for later non-PCH split platforms such as VLV.
> >
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> The bit is mbz on VLV, so I guess it should be 0, but better safe than
> sorry, and it gets rid of a useless register read.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-24 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-24 13:44 [PATCH] drm/i915: backlight combination mode bit is gen4 only Jani Nikula
2013-09-24 14:41 ` Ville Syrjälä
2013-09-24 15:04 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox