From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: backlight combination mode bit is gen4 only Date: Tue, 24 Sep 2013 17:04:39 +0200 Message-ID: <20130924150413.GA12663@phenom.ffwll.local> References: <1380030279-9745-1-git-send-email-jani.nikula@intel.com> <20130924144121.GD4531@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by gabe.freedesktop.org (Postfix) with ESMTP id BDA0DE76C1 for ; Tue, 24 Sep 2013 08:04:27 -0700 (PDT) Received: by mail-ee0-f51.google.com with SMTP id c1so2554365eek.10 for ; Tue, 24 Sep 2013 08:04:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130924144121.GD4531@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 24, 2013 at 05:41:21PM +0300, Ville Syrj=E4l=E4 wrote: > On Tue, Sep 24, 2013 at 04:44:39PM +0300, Jani Nikula wrote: > > Not valid for later non-PCH split platforms such as VLV. > > = > > Signed-off-by: Jani Nikula > = > The bit is mbz on VLV, so I guess it should be 0, but better safe than > sorry, and it gets rid of a useless register read. > = > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch