From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/13] drm/i915: Move the conditional seqno query into the tracepoint
Date: Tue, 24 Sep 2013 21:50:58 +0300 [thread overview]
Message-ID: <20130924185058.GG4531@intel.com> (raw)
In-Reply-To: <1379968410-14428-3-git-send-email-rodrigo.vivi@gmail.com>
On Mon, Sep 23, 2013 at 05:33:19PM -0300, Rodrigo Vivi wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> We only wish to know the value of seqno when emitting the tracepoint, so
> move the query from a parameter to the macro to inside the conditional
> macro body so that the query is only evaluated when required.
>
> Reviewer: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Looks OK to me.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 2 +-
> drivers/gpu/drm/i915/i915_trace.h | 21 ++++++++++++++++++---
> 2 files changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index b356dc1..84b7efc 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -807,7 +807,7 @@ static void notify_ring(struct drm_device *dev,
> if (ring->obj == NULL)
> return;
>
> - trace_i915_gem_request_complete(ring, ring->get_seqno(ring, false));
> + trace_i915_gem_request_complete(ring);
>
> wake_up_all(&ring->irq_queue);
> i915_queue_hangcheck(dev);
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index e2c5ee6..a1797f6 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -304,9 +304,24 @@ DEFINE_EVENT(i915_gem_request, i915_gem_request_add,
> TP_ARGS(ring, seqno)
> );
>
> -DEFINE_EVENT(i915_gem_request, i915_gem_request_complete,
> - TP_PROTO(struct intel_ring_buffer *ring, u32 seqno),
> - TP_ARGS(ring, seqno)
> +TRACE_EVENT(i915_gem_request_complete,
> + TP_PROTO(struct intel_ring_buffer *ring),
> + TP_ARGS(ring),
> +
> + TP_STRUCT__entry(
> + __field(u32, dev)
> + __field(u32, ring)
> + __field(u32, seqno)
> + ),
> +
> + TP_fast_assign(
> + __entry->dev = ring->dev->primary->index;
> + __entry->ring = ring->id;
> + __entry->seqno = ring->get_seqno(ring, false);
> + ),
> +
> + TP_printk("dev=%u, ring=%u, seqno=%u",
> + __entry->dev, __entry->ring, __entry->seqno)
> );
>
> DEFINE_EVENT(i915_gem_request, i915_gem_request_retire,
> --
> 1.8.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-09-24 18:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 20:33 [PATCH 00/13] drm-intel-collector - review request Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 01/13] drm/i915: check that the i965g/gm 4G limit is really obeyed Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 02/13] drm/i915: Move the conditional seqno query into the tracepoint Rodrigo Vivi
2013-09-24 18:50 ` Ville Syrjälä [this message]
2013-09-24 19:20 ` Daniel Vetter
2013-09-23 20:33 ` [PATCH 03/13] drm/i915: Add some missing steps to i915_driver_load error path Rodrigo Vivi
2013-10-02 17:00 ` Daniel Vetter
2013-09-23 20:33 ` [PATCH 04/13] drm/i915: Asynchronously perform the set-base for a simple modeset Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 05/13] drm/i915: Align tiled scanouts from stolen memory to 256k in the GTT Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 06/13] drm/i915: Pair seqno completion tracepoint with its dispatch Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 07/13] drm/i915: Initialise min/max frequencies before updating RPS registers Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 08/13] drm/i915: Delay the relase of the forcewake by a jiffie Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 09/13] drm/i915: Add a tracepoint for using a semaphore Rodrigo Vivi
2013-09-25 9:34 ` Ville Syrjälä
2013-09-25 10:11 ` Daniel Vetter
2013-09-25 10:43 ` [PATCH] " Chris Wilson
2013-09-25 11:29 ` Ville Syrjälä
2013-09-25 11:31 ` Daniel Vetter
2013-09-23 20:33 ` [PATCH 10/13] drm/i915: Boost RPS frequency for CPU stalls Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 11/13] drm/i915: Tweak RPS thresholds to more aggressively downclock Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 12/13] drm/i915: Allow GT3 Slice Shutdown on Boot Rodrigo Vivi
2013-09-23 20:33 ` [PATCH 13/13] drm/i915: Allow Dynamically GT3 Slice Shutdown Rodrigo Vivi
2013-09-23 21:13 ` Chris Wilson
2013-09-24 10:15 ` [PATCH 00/13] drm-intel-collector - review request Daniel Vetter
2013-09-24 10:32 ` Chris Wilson
2013-09-24 10:47 ` Daniel Vetter
2013-09-24 11:11 ` Chris Wilson
2013-09-24 11:22 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924185058.GG4531@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox