From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 09/13] drm/i915: Add a tracepoint for using a semaphore Date: Wed, 25 Sep 2013 12:11:12 +0200 Message-ID: <20130925101112.GK12663@phenom.ffwll.local> References: <1379968410-14428-1-git-send-email-rodrigo.vivi@gmail.com> <1379968410-14428-10-git-send-email-rodrigo.vivi@gmail.com> <20130925093437.GL4531@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f169.google.com (mail-ea0-f169.google.com [209.85.215.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 60DC0E6039 for ; Wed, 25 Sep 2013 03:10:58 -0700 (PDT) Received: by mail-ea0-f169.google.com with SMTP id k11so3116771eaj.28 for ; Wed, 25 Sep 2013 03:10:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130925093437.GL4531@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Sep 25, 2013 at 12:34:37PM +0300, Ville Syrj=E4l=E4 wrote: > On Mon, Sep 23, 2013 at 05:33:26PM -0300, Rodrigo Vivi wrote: > > From: Chris Wilson > > = > > So that we can find the callers who introduce a ring stall. A single > > ring stall is not too unwelcome, the right issue becomes when they start > > to interlock and prevent any concurrent work. That, however, is a little > > tricker to detect with a mere tracepoint! > > = > > v2: Rebrand it as a ring event, rather than an object event. > > = > > Signed-off-by: Chris Wilson > > Signed-off-by: Rodrigo Vivi > = > Just wondering if we would want to see the seqno(s) in the trace as well? Hm yeah, I guess the seqno we're syncing on the from ring would be useful to gauge how much parallelism there really is. Chris, care to respin? -Daniel > = > But anyway, the patch looks fine. > Reviewed-by: Ville Syrj=E4l=E4 > = > > --- > > drivers/gpu/drm/i915/i915_gem.c | 2 ++ > > drivers/gpu/drm/i915/i915_trace.h | 19 +++++++++++++++++++ > > 2 files changed, 21 insertions(+) > > = > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i91= 5_gem.c > > index d68cc5c..4a16491 100644 > > --- a/drivers/gpu/drm/i915/i915_gem.c > > +++ b/drivers/gpu/drm/i915/i915_gem.c > > @@ -2614,6 +2614,8 @@ i915_gem_object_sync(struct drm_i915_gem_object *= obj, > > if (ret) > > return ret; > > = > > + trace_i915_gem_ring_sync_to(from, to); > > + > > ret =3D to->sync_to(to, from, seqno); > > if (!ret) > > /* We use last_read_seqno because sync_to() > > diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i= 915_trace.h > > index 5c8e36a..48e8f07 100644 > > --- a/drivers/gpu/drm/i915/i915_trace.h > > +++ b/drivers/gpu/drm/i915/i915_trace.h > > @@ -233,6 +233,25 @@ TRACE_EVENT(i915_gem_evict_everything, > > TP_printk("dev=3D%d", __entry->dev) > > ); > > = > > +TRACE_EVENT(i915_gem_ring_sync_to, > > + TP_PROTO(struct intel_ring_buffer *from, struct intel_ring_buffer= *to), > > + TP_ARGS(from, to), > > + > > + TP_STRUCT__entry( > > + __field(u32, dev) > > + __field(u32, sync_from) > > + __field(u32, sync_to) > > + ), > > + > > + TP_fast_assign( > > + __entry->dev =3D from->dev->primary->index; > > + __entry->sync_from =3D from->id; > > + __entry->sync_to =3D to->id; > > + ), > > + > > + TP_printk("dev=3D%u, sync-from=3D%u, sync-to=3D%u", __entry->dev,= __entry->sync_from, __entry->sync_to) > > +); > > + > > TRACE_EVENT(i915_gem_ring_dispatch, > > TP_PROTO(struct intel_ring_buffer *ring, u32 flags), > > TP_ARGS(ring, flags), > > -- = > > 1.8.1.4 > > = > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > -- = > Ville Syrj=E4l=E4 > Intel OTC > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch