From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Add a tracepoint for using a semaphore Date: Wed, 25 Sep 2013 13:31:13 +0200 Message-ID: <20130925113113.GM12663@phenom.ffwll.local> References: <20130925101112.GK12663@phenom.ffwll.local> <1380105808-28151-1-git-send-email-chris@chris-wilson.co.uk> <20130925112934.GM4531@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com [209.85.215.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F961E6B23 for ; Wed, 25 Sep 2013 04:30:57 -0700 (PDT) Received: by mail-ea0-f179.google.com with SMTP id b10so3085979eae.38 for ; Wed, 25 Sep 2013 04:30:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130925112934.GM4531@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Sep 25, 2013 at 02:29:34PM +0300, Ville Syrj=E4l=E4 wrote: > On Wed, Sep 25, 2013 at 11:43:28AM +0100, Chris Wilson wrote: > > So that we can find the callers who introduce a ring stall. A single > > ring stall is not too unwelcome, the right issue becomes when they start > > to interlock and prevent any concurrent work. That, however, is a little > > tricker to detect with a mere tracepoint! > > = > > v2: Rebrand it as a ring event, rather than an object event. > > v3: Include the seqno in the tracepoint for posterity or something. > > = > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/i915_gem.c | 1 + > > drivers/gpu/drm/i915/i915_trace.h | 26 ++++++++++++++++++++++++++ > > 2 files changed, 27 insertions(+) > > = > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i91= 5_gem.c > > index 82bc029..fa3b373 100644 > > --- a/drivers/gpu/drm/i915/i915_gem.c > > +++ b/drivers/gpu/drm/i915/i915_gem.c > > @@ -2625,6 +2625,7 @@ i915_gem_object_sync(struct drm_i915_gem_object *= obj, > > if (ret) > > return ret; > > = > > + trace_i915_gem_ring_sync_to(from, to, seqno); > > ret =3D to->sync_to(to, from, seqno); > = > Passing the rings in the same order to both might avoid some confusion, > but I don't care enough to withhold my r-b so: > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch