From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Restore global mappings upon resume
Date: Thu, 26 Sep 2013 09:38:41 -0700 [thread overview]
Message-ID: <20130926163841.GC9309@bwidawsk.net> (raw)
In-Reply-To: <20130926161653.GA11811@nuc-i3427.alporthouse.com>
On Thu, Sep 26, 2013 at 05:16:53PM +0100, Chris Wilson wrote:
> On Thu, Sep 26, 2013 at 09:04:53AM -0700, Ben Widawsky wrote:
> > On Thu, Sep 26, 2013 at 09:22:45AM +0100, Chris Wilson wrote:
> > > + obj->has_global_gtt_mapping = false;
> > > + obj->has_aliasing_ppgtt_mapping = false;
> >
> > Actually, the aliasing PPGTT mapping may very well still be in tact.
> > Unless I'm not seeing something that you are.
>
> I was about to agree with you, but we zap the PDEs in the clear_range()
> above and don't otherwise restore them, so it looks like without that
> optimisation we need to clear the ppgtt flag as well.
> -Chris
>
Having trouble finding it on the interwebs. Please see:
1375315222-4785-15-git-send-email-ben@bwidawsk.net
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-09-26 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 8:22 [PATCH] drm/i915: Restore global mappings upon resume Chris Wilson
2013-09-26 16:04 ` Ben Widawsky
2013-09-26 16:16 ` Chris Wilson
2013-09-26 16:38 ` Ben Widawsky [this message]
2013-09-26 20:08 ` Chris Wilson
2013-09-26 21:59 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2013-09-26 8:20 Chris Wilson
2013-09-26 8:04 Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130926163841.GC9309@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox