From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915: Restore global mappings upon resume Date: Thu, 26 Sep 2013 09:38:41 -0700 Message-ID: <20130926163841.GC9309@bwidawsk.net> References: <1380183765-5719-1-git-send-email-chris@chris-wilson.co.uk> <20130926160452.GA9309@bwidawsk.net> <20130926161653.GA11811@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A547E6DD2 for ; Thu, 26 Sep 2013 09:39:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130926161653.GA11811@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 26, 2013 at 05:16:53PM +0100, Chris Wilson wrote: > On Thu, Sep 26, 2013 at 09:04:53AM -0700, Ben Widawsky wrote: > > On Thu, Sep 26, 2013 at 09:22:45AM +0100, Chris Wilson wrote: > > > + obj->has_global_gtt_mapping = false; > > > + obj->has_aliasing_ppgtt_mapping = false; > > > > Actually, the aliasing PPGTT mapping may very well still be in tact. > > Unless I'm not seeing something that you are. > > I was about to agree with you, but we zap the PDEs in the clear_range() > above and don't otherwise restore them, so it looks like without that > optimisation we need to clear the ppgtt flag as well. > -Chris > Having trouble finding it on the interwebs. Please see: 1375315222-4785-15-git-send-email-ben@bwidawsk.net -- Ben Widawsky, Intel Open Source Technology Center