From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 2/5] drm/i915: use wait_event_timeout when waiting for flip completions Date: Fri, 27 Sep 2013 14:27:59 -0700 Message-ID: <20130927142759.3ecf70e9@jbarnes-desktop> References: <1380311846-1581-1-git-send-email-jbarnes@virtuousgeek.org> <1380311846-1581-2-git-send-email-jbarnes@virtuousgeek.org> <20130927204539.GD744@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy14-pub.mail.unifiedlayer.com (oproxy14-pub.mail.unifiedlayer.com [67.222.51.224]) by gabe.freedesktop.org (Postfix) with SMTP id CE8D9E6855 for ; Fri, 27 Sep 2013 14:33:54 -0700 (PDT) In-Reply-To: <20130927204539.GD744@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 27 Sep 2013 21:45:39 +0100 Chris Wilson wrote: > On Fri, Sep 27, 2013 at 12:57:23PM -0700, Jesse Barnes wrote: > > We're shutting the crtc off and don't want to hang forever. > > That scares me ever so slightly, especially ignoring the failure. Do you > want to reset the display controller if the interrupts die, or just > report a WARN, or propagate the failure back and make userspace try > again? > > But not taking any action at all is a recipe for a silent disaster. It > has taken years to get to the point where we can turn off the pipes > reliably... Yeah this one is definitely a WIP. I'd like to warn when this happens and clean things up rather than just timing out and letting disaster befall us later. -- Jesse Barnes, Intel Open Source Technology Center