public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 0/9] drm/i915: Plane rotation support
Date: Mon, 30 Sep 2013 21:36:59 +0300	[thread overview]
Message-ID: <20130930183659.GH9395@intel.com> (raw)
In-Reply-To: <CAKMK7uHN0MVqN7RUqBipuES57EL9J3XtZX7gstDsxOawsXa_8A@mail.gmail.com>

On Mon, Sep 30, 2013 at 08:21:33PM +0200, Daniel Vetter wrote:
> On Mon, Sep 30, 2013 at 7:46 PM, Rob Clark <robdclark@gmail.com> wrote:
> > I guess the main thing I care about is that we don't advertise things
> > to userspace that we can't actually do.  I'm not sure what other hw
> > out there supports rotation in hw in some form or another, but it
> > might be a good time to hear from 'em about whether these property
> > values work for them or not.
> 
> Hm, I've thought the plan was to let userspace figure that out with a
> dry-run flag, and if a certain configuration doesn't work it needs to
> fall back to rendering-based compositioning for the given surface. I
> don't think there's really much more we can do for fully generic
> compositors.

Yeah, if no one comes up with anything better, the trial and error
approach is the plan in my mind.

But in case the hardware never ever supports certain property/value I
think we shouldn't expose it. Like 90/270 degree rotation in case of
intel hardware.

> Tha might leave strange hw in the dust where planes aren't symmetric
> in capabilities and hence a simple linear walk over surfaces/planes,
> ordered by bw-savings or so, yields extermely bad surface->plane
> assignements. But  my impression is that hw is moving to unified
> stacks of planes so I hope we can punt on solving this in a generic
> way (and resort to quick platform hacks in userspace where it's really
> needed to hit e.g. video playback power targets).

Right. If someone has really specific needs I think they can just go
and write their own compositor (or plugin if the compositor in question
has such things).

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2013-09-30 18:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 14:44 [PATCH 0/9] drm/i915: Plane rotation support ville.syrjala
2013-09-30 14:44 ` [PATCH 1/9] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h ville.syrjala
2013-09-30 14:44 ` [PATCH 2/9] drm: Add support_bits parameter to drm_property_create_bitmask() ville.syrjala
2013-09-30 14:44 ` [PATCH 3/9] drm: Add drm_mode_create_rotation_property() ville.syrjala
2013-09-30 14:44 ` [PATCH 4/9] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property() ville.syrjala
2013-09-30 14:44 ` [PATCH 5/9] drm: Add drm_rect rotation functions ville.syrjala
2013-09-30 14:44 ` [PATCH 6/9] drm: Add drm_rotation_simplify() ville.syrjala
2013-10-14 13:46   ` [Intel-gfx] " Imre Deak
2013-10-14 13:50     ` Ville Syrjälä
2013-09-30 14:44 ` [PATCH 7/9] drm/i915: Add 180 degree sprite rotation support ville.syrjala
2013-10-01 13:22   ` [PATCH v2 " ville.syrjala
2013-09-30 14:44 ` [PATCH 8/9] drm/i915: Make intel_plane_restore() return an error ville.syrjala
2013-09-30 14:44 ` [PATCH 9/9] drm/i915: Add rotation property for sprites ville.syrjala
2013-10-14 13:59   ` Imre Deak
2013-10-14 14:39     ` Ville Syrjälä
2013-10-14 15:10       ` Imre Deak
2013-09-30 16:15 ` [PATCH 0/9] drm/i915: Plane rotation support Rob Clark
2013-09-30 17:09   ` Ville Syrjälä
2013-09-30 17:46     ` Rob Clark
2013-09-30 18:21       ` Daniel Vetter
2013-09-30 18:36         ` Ville Syrjälä [this message]
2013-09-30 18:31       ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130930183659.GH9395@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox