From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/hsw: Disable L3 caching of atomic memory operations.
Date: Wed, 2 Oct 2013 15:31:47 -0700 [thread overview]
Message-ID: <20131002223147.GA6580@bwidawsk.net> (raw)
In-Reply-To: <CAKMK7uErnpuPgvw3smAtbpH6TvH_K8VjqS59c0rtQ+yW1yxwFw@mail.gmail.com>
On Thu, Oct 03, 2013 at 12:20:43AM +0200, Daniel Vetter wrote:
> On Thu, Oct 3, 2013 at 12:03 AM, Francisco Jerez <currojerez@riseup.net> wrote:
> > + case I915_PARAM_HAS_ATOMICS:
> > + value = 1;
> > + break;
>
> Generally when we do kernel fixes for gpu hangs like that we don't add
> parameters (would drown in them otherwise) but simply queue it up to
> -fixes and slap a cc: stable on it. Gpu hang fixes are critical enough
> imo for that treatment, even when it's for brand new userspace code.
>
> Any specific reason why we shouldn't follow this approach here? I'd
> make the patch simpler and we could dump a bit of userspace code, too.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
They haven't yet enabled this feature in mesa, so it's not exactly
fixing a hang. It is preventing one from ever occurring. Mesa versions
built against an older libdrm will not use atomics.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-02 22:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 22:03 [PATCH] drm/i915/hsw: Disable L3 caching of atomic memory operations Francisco Jerez
2013-10-02 22:16 ` Ben Widawsky
2013-10-02 22:20 ` Daniel Vetter
2013-10-02 22:31 ` Francisco Jerez
2013-10-02 22:31 ` Ben Widawsky [this message]
2013-10-02 22:53 ` Francisco Jerez
2013-10-03 7:35 ` Daniel Vetter
2013-10-03 1:36 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002223147.GA6580@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox