* [PATCH] drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio.
@ 2013-09-25 20:51 Rodrigo Vivi
2013-09-25 20:59 ` Rodrigo Vivi
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2013-09-25 20:51 UTC (permalink / raw)
To: intel-gfx
Power Well in use forces constantly PSR to exit.
On recent Kernel I noticed that PSR Performance Counter was always 0
indicating that PSR was never really achieved.
By masking LPSP, PSR can work normally and save power on Haswell.
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 79c14e2..2c555f9 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1467,7 +1467,7 @@ static void intel_edp_psr_setup(struct intel_dp *intel_dp)
/* Avoid continuous PSR exit by masking memup and hpd */
I915_WRITE(EDP_PSR_DEBUG_CTL, EDP_PSR_DEBUG_MASK_MEMUP |
- EDP_PSR_DEBUG_MASK_HPD);
+ EDP_PSR_DEBUG_MASK_HPD | EDP_PSR_DEBUG_MASK_LPSP);
intel_dp->psr_setup_done = true;
}
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio.
2013-09-25 20:51 [PATCH] drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio Rodrigo Vivi
@ 2013-09-25 20:59 ` Rodrigo Vivi
2013-09-25 21:25 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2013-09-25 20:59 UTC (permalink / raw)
To: intel-gfx
Hi Daniel,
Please consider to accept this for -fixes, otherwise PSR will never
work on Haswell on 3.12.
Thanks,
Rodrigo.
On Wed, Sep 25, 2013 at 5:51 PM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> Power Well in use forces constantly PSR to exit.
> On recent Kernel I noticed that PSR Performance Counter was always 0
> indicating that PSR was never really achieved.
> By masking LPSP, PSR can work normally and save power on Haswell.
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 79c14e2..2c555f9 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1467,7 +1467,7 @@ static void intel_edp_psr_setup(struct intel_dp *intel_dp)
>
> /* Avoid continuous PSR exit by masking memup and hpd */
> I915_WRITE(EDP_PSR_DEBUG_CTL, EDP_PSR_DEBUG_MASK_MEMUP |
> - EDP_PSR_DEBUG_MASK_HPD);
> + EDP_PSR_DEBUG_MASK_HPD | EDP_PSR_DEBUG_MASK_LPSP);
>
> intel_dp->psr_setup_done = true;
> }
> --
> 1.7.11.7
>
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio.
2013-09-25 20:59 ` Rodrigo Vivi
@ 2013-09-25 21:25 ` Daniel Vetter
2013-10-01 18:28 ` Rodrigo Vivi
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2013-09-25 21:25 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On Wed, Sep 25, 2013 at 10:59 PM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> Please consider to accept this for -fixes, otherwise PSR will never
> work on Haswell on 3.12.
You know the drill: A feature regressed and no one noticed, which
means we are lacking a fully automated testcase. I guess we need to
expose in debugfs somewhere if the edp panel can do psr (if we don't
do that already) to be able to skip the test correctly and then check
with a little igt testcase that we actually achieve psr residency.
Also please poke QA to make sure they actually have a hsw platform
with psr panel.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio.
2013-09-25 21:25 ` Daniel Vetter
@ 2013-10-01 18:28 ` Rodrigo Vivi
2013-10-03 16:31 ` Rodrigo Vivi
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2013-10-01 18:28 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
Reporter of that Jira bugs confirmed this patch fixes the issue.
debufs simplification and igt test case submited.
Thanks
On Wed, Sep 25, 2013 at 6:25 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Sep 25, 2013 at 10:59 PM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
>> Please consider to accept this for -fixes, otherwise PSR will never
>> work on Haswell on 3.12.
>
> You know the drill: A feature regressed and no one noticed, which
> means we are lacking a fully automated testcase. I guess we need to
> expose in debugfs somewhere if the edp panel can do psr (if we don't
> do that already) to be able to skip the test correctly and then check
> with a little igt testcase that we actually achieve psr residency.
> Also please poke QA to make sure they actually have a hsw platform
> with psr panel.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio.
2013-10-01 18:28 ` Rodrigo Vivi
@ 2013-10-03 16:31 ` Rodrigo Vivi
2013-10-03 17:53 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2013-10-03 16:31 UTC (permalink / raw)
To: intel-gfx
Power Well in use forces constantly PSR to exit.
On recent Kernel I noticed that PSR Performance Counter was always 0
indicating that PSR was never really achieved.
By masking LPSP, PSR can work normally and save power on Haswell.
Two bugs had been raised with PSR flag enabled:
- "Screen flickers when booted by enabling PSR in the kernel (i915.enable_psr=1) , the system is booting to a gray screen."
- "When booting the DUT with PSR feature enabled in the kernel (i915.enable_psr=1) , the system is booting to a gray screen."
Both bugs has been fixed by this patch.
v2: proper comment for -fixes
Tested-by: Selvaraj, Elavarasan <elavarasanx.selvaraj@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 79c14e2..2c555f9 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1467,7 +1467,7 @@ static void intel_edp_psr_setup(struct intel_dp *intel_dp)
/* Avoid continuous PSR exit by masking memup and hpd */
I915_WRITE(EDP_PSR_DEBUG_CTL, EDP_PSR_DEBUG_MASK_MEMUP |
- EDP_PSR_DEBUG_MASK_HPD);
+ EDP_PSR_DEBUG_MASK_HPD | EDP_PSR_DEBUG_MASK_LPSP);
intel_dp->psr_setup_done = true;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio.
2013-10-03 16:31 ` Rodrigo Vivi
@ 2013-10-03 17:53 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2013-10-03 17:53 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On Thu, Oct 03, 2013 at 01:31:26PM -0300, Rodrigo Vivi wrote:
> Power Well in use forces constantly PSR to exit.
> On recent Kernel I noticed that PSR Performance Counter was always 0
> indicating that PSR was never really achieved.
> By masking LPSP, PSR can work normally and save power on Haswell.
>
> Two bugs had been raised with PSR flag enabled:
> - "Screen flickers when booted by enabling PSR in the kernel (i915.enable_psr=1) , the system is booting to a gray screen."
> - "When booting the DUT with PSR feature enabled in the kernel (i915.enable_psr=1) , the system is booting to a gray screen."
>
> Both bugs has been fixed by this patch.
>
> v2: proper comment for -fixes
>
> Tested-by: Selvaraj, Elavarasan <elavarasanx.selvaraj@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-03 17:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-25 20:51 [PATCH] drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio Rodrigo Vivi
2013-09-25 20:59 ` Rodrigo Vivi
2013-09-25 21:25 ` Daniel Vetter
2013-10-01 18:28 ` Rodrigo Vivi
2013-10-03 16:31 ` Rodrigo Vivi
2013-10-03 17:53 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox