* [PATCH] drm/i915: Call io_schedule() whilst whilsting for the GPU
@ 2013-10-04 8:58 Chris Wilson
2013-10-04 9:14 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Chris Wilson @ 2013-10-04 8:58 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
Since we are waiting upon IO completion, inform the kernel through use
of the io_schedule() call rather than the regular schedule(). This
should allow the kernel to make better decisions regarding scheduling
and power management.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 825d8ea35e08..6f2db61fc65b 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1179,7 +1179,7 @@ static int __wait_seqno(struct intel_ring_buffer *ring, u32 seqno,
mod_timer(&timer, expire);
}
- schedule();
+ io_schedule();
if (timeout)
timeout_jiffies = expire - jiffies;
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: Call io_schedule() whilst whilsting for the GPU
2013-10-04 8:58 [PATCH] drm/i915: Call io_schedule() whilst whilsting for the GPU Chris Wilson
@ 2013-10-04 9:14 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2013-10-04 9:14 UTC (permalink / raw)
To: Chris Wilson; +Cc: Daniel Vetter, intel-gfx
On Fri, Oct 04, 2013 at 09:58:46AM +0100, Chris Wilson wrote:
> Since we are waiting upon IO completion, inform the kernel through use
> of the io_schedule() call rather than the regular schedule(). This
> should allow the kernel to make better decisions regarding scheduling
> and power management.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Yeah, I like. Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-04 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-04 8:58 [PATCH] drm/i915: Call io_schedule() whilst whilsting for the GPU Chris Wilson
2013-10-04 9:14 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox