From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix type mismatch and accounting in i915_gem_shrink Date: Fri, 4 Oct 2013 14:38:45 +0200 Message-ID: <20131004123845.GO31334@phenom.ffwll.local> References: <20130924102959.GK13668@phenom.ffwll.local> <1380879180-4976-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id CE7F4E7CAC for ; Fri, 4 Oct 2013 05:38:28 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id d41so1780218eek.36 for ; Fri, 04 Oct 2013 05:38:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1380879180-4976-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Oct 04, 2013 at 10:33:00AM +0100, Chris Wilson wrote: > The interface uses an unsigned long, and we can use the unsigned counter > throughout our code, so do so. In the process, we notice one instance > where the shrink count is based on a heuristic rather than the result, > and another where we ask for too many pages to be purged. > > v2: nr_to_scan needs to be promoted to a long as well, so just use > sc->nr_to_scan directly. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch