From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915/dp: use sizeof for memset instead of magic value Date: Fri, 4 Oct 2013 14:44:29 +0200 Message-ID: <20131004124429.GR31334@phenom.ffwll.local> References: <1380888528-4507-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com [209.85.215.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 209A6E5CE8 for ; Fri, 4 Oct 2013 05:44:10 -0700 (PDT) Received: by mail-ea0-f182.google.com with SMTP id o10so1799290eaj.13 for ; Fri, 04 Oct 2013 05:44:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1380888528-4507-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Oct 04, 2013 at 03:08:47PM +0300, Jani Nikula wrote: > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 60118da..0ed7717 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -2406,7 +2406,7 @@ static bool > intel_dp_reset_link_train(struct intel_dp *intel_dp, uint32_t *DP, > uint8_t dp_train_pat) > { > - memset(intel_dp->train_set, 0, 4); > + memset(intel_dp->train_set, 0, sizeof(intel_dp->train_set)); Oh, missed that one in my big review of alloc/memset. Patch merged, thanks. -Daniel > intel_dp_set_signal_levels(intel_dp, DP); > return intel_dp_set_link_train(intel_dp, DP, dp_train_pat); > } > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch