From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/dp: promote clock recovery failures to DRM_ERROR
Date: Sat, 5 Oct 2013 18:23:45 +0200 [thread overview]
Message-ID: <20131005162345.GW31334@phenom.ffwll.local> (raw)
In-Reply-To: <1380978836-12168-1-git-send-email-jani.nikula@intel.com>
On Sat, Oct 05, 2013 at 04:13:56PM +0300, Jani Nikula wrote:
> If channel equalization succeeds, there's no indication something went
> wrong in clock recovery (unless debug is enabled). We should shout about
> the failures and fix them instead of hiding them under the carpet.
>
> This has allowed bugs like [1] stay dormant for a long time.
>
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=70117
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Yeah, makes tons of sense. Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-10-05 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 13:13 [PATCH] drm/i915/dp: promote clock recovery failures to DRM_ERROR Jani Nikula
2013-10-05 16:23 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131005162345.GW31334@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox