From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915/dp: promote clock recovery failures to DRM_ERROR Date: Sat, 5 Oct 2013 18:23:45 +0200 Message-ID: <20131005162345.GW31334@phenom.ffwll.local> References: <1380978836-12168-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 90203E5CC2 for ; Sat, 5 Oct 2013 09:23:28 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id b47so2374806eek.17 for ; Sat, 05 Oct 2013 09:23:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1380978836-12168-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Oct 05, 2013 at 04:13:56PM +0300, Jani Nikula wrote: > If channel equalization succeeds, there's no indication something went > wrong in clock recovery (unless debug is enabled). We should shout about > the failures and fix them instead of hiding them under the carpet. > > This has allowed bugs like [1] stay dormant for a long time. > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=70117 > > Signed-off-by: Jani Nikula Yeah, makes tons of sense. Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch