From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/2] drm/i915/hsw: Add
 I915_EXEC_RESOURCE_STREAMER flag
Date: Tue, 8 Oct 2013 16:38:31 -0700
Message-ID: <20131008233831.GC27157@bwidawsk.net>
References: <1381266592-7558-1-git-send-email-abdiel.janulgue@linux.intel.com>
	<1381266592-7558-2-git-send-email-abdiel.janulgue@linux.intel.com>
	<20131008215050.GJ4454@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id CE873E5D2F
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  8 Oct 2013 16:38:46 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20131008215050.GJ4454@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Abdiel Janulgue <abdiel.janulgue@linux.intel.com>, intel-gfx@lists.freedesktop.org, daniel@ffwll.ch
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Oct 08, 2013 at 10:50:50PM +0100, Chris Wilson wrote:
> On Wed, Oct 09, 2013 at 12:09:51AM +0300, Abdiel Janulgue wrote:
> > Ensures that the batch buffer is executed by the resource streamer.
> > 
> > Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_gem_execbuffer.c |    2 ++
> >  include/uapi/drm/i915_drm.h                |    5 +++++
> >  2 files changed, 7 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > index 0ce0d47..4a56c58 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > @@ -962,6 +962,8 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
> >  	case I915_EXEC_DEFAULT:
> >  	case I915_EXEC_RENDER:
> >  		ring = &dev_priv->ring[RCS];
> > +		flags |= (args->flags & I915_EXEC_RESOURCE_STREAMER) ?
> > +		  I915_EXEC_RESOURCE_STREAMER : 0;
> 
> Besides this being flags |= args->flags & I915_EXEC_RESOURCE_STREAMER;
> flags is a completely different bitfield and you should be translating
> into a dispatch value rather than the execbuffer value.
> -Chris
> 

To decrypt Chris just a bit, though he was rather more verbose than
usual ;-), see the translation of I915_EXEC_SECURE to
I915_DISPATCH_SECURE.

-- 
Ben Widawsky, Intel Open Source Technology Center