From: "Lee, Chon Ming" <chon.ming.lee@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
David Herrmann <dh.herrmann@gmail.com>
Subject: Re: [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support
Date: Wed, 9 Oct 2013 14:35:52 +0800 [thread overview]
Message-ID: <20131009063552.GL20415@ubuntu.png.intel.com> (raw)
In-Reply-To: <1381247089-7960-3-git-send-email-daniel.vetter@ffwll.ch>
On 10/08 17:44, Daniel Vetter wrote:
>
> mutex_lock(&dev->mode_config.fb_lock);
> list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) {
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index f221631..057ddeb 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -1416,6 +1416,7 @@ void i915_master_destroy(struct drm_device *dev, struct drm_master *master)
> master->driver_priv = NULL;
> }
>
> +#ifdef CONFIG_FB
Why use CONFIG_FB here, as this is i915, should use CONFIG_DRM_I915_FBDEV right?
> static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv)
> {
> struct apertures_struct *ap;
> @@ -1436,6 +1437,11 @@ static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv)
>
> kfree(ap);
> }
> +#else
> +static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv)
> +{
> +}
> +#endif
>
Regards,
Chon Ming
next prev parent reply other threads:[~2013-10-09 6:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 15:44 [PATCH 0/3] fbdev-less i915, take 2 Daniel Vetter
2013-10-08 15:44 ` [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers Daniel Vetter
2013-10-08 16:52 ` Rob Clark
2013-10-11 21:36 ` Daniel Vetter
2013-10-08 15:44 ` [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support Daniel Vetter
2013-10-09 6:35 ` Lee, Chon Ming [this message]
2013-10-09 7:18 ` [PATCH] " Daniel Vetter
2013-10-09 8:09 ` [Intel-gfx] " Chris Wilson
2013-10-09 8:33 ` Daniel Vetter
2013-10-09 9:33 ` [Intel-gfx] " Jani Nikula
2013-10-11 5:53 ` Lee, Chon Ming
2013-10-11 21:37 ` Daniel Vetter
2013-10-08 15:44 ` [PATCH 3/3] drm/i915: rename intel_fb.c to intel_fbdev.c Daniel Vetter
2013-10-08 15:59 ` [PATCH 0/3] fbdev-less i915, take 2 Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2013-06-16 14:57 [PATCH 0/3] fbdev no more! Daniel Vetter
2013-06-16 14:57 ` [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009063552.GL20415@ubuntu.png.intel.com \
--to=chon.ming.lee@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox