From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/i915: prevent tiling changes on framebuffer backing storage Date: Thu, 10 Oct 2013 00:02:17 +0200 Message-ID: <20131009220217.GS8303@phenom.ffwll.local> References: <1381346634-17973-1-git-send-email-daniel.vetter@ffwll.ch> <1381346634-17973-3-git-send-email-daniel.vetter@ffwll.ch> <20131009212939.GB1604@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com [209.85.215.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C704E7EF7 for ; Wed, 9 Oct 2013 15:01:59 -0700 (PDT) Received: by mail-ea0-f181.google.com with SMTP id d10so709985eaj.26 for ; Wed, 09 Oct 2013 15:01:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20131009212939.GB1604@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 09, 2013 at 10:29:39PM +0100, Chris Wilson wrote: > On Wed, Oct 09, 2013 at 09:23:52PM +0200, Daniel Vetter wrote: > > Assuming that all framebuffer related metadata is invariant simplifies > > our userspace input data checking. And current userspace always first > > updates the tiling of an object before creating a framebuffer with it. > > Userspace already changes the tiling layout whilst keeping the fb id. How exactly does that work? You can't really change the fb pitch without creating a new one ... That leaves switching from tiled to untiled and back I think. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch