From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: tell the user KMS is required for gen6+ Date: Thu, 10 Oct 2013 17:28:54 +0300 Message-ID: <20131010142854.GO13047@intel.com> References: <1381407937-4470-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id AACCCE7613 for ; Thu, 10 Oct 2013 07:28:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1381407937-4470-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Oct 10, 2013 at 03:25:37PM +0300, Jani Nikula wrote: > Educate the users why i915 won't load on gen6+ and nomodeset. > = > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=3D61671 > Signed-off-by: Jani Nikula Yes, much better than the agp wtf error people get currently. Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/i915_dma.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_= dma.c > index 0c86c48..9a54241 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1477,8 +1477,11 @@ int i915_driver_load(struct drm_device *dev, unsig= ned long flags) > info =3D (struct intel_device_info *) flags; > = > /* Refuse to load on gen6+ without kms enabled. */ > - if (info->gen >=3D 6 && !drm_core_check_feature(dev, DRIVER_MODESET)) > + if (info->gen >=3D 6 && !drm_core_check_feature(dev, DRIVER_MODESET)) { > + DRM_INFO("Your hardware requires kernel modesetting (KMS)\n"); > + DRM_INFO("See CONFIG_DRM_I915_KMS, nomodeset, and i915.modeset paramet= ers\n"); > return -ENODEV; > + } > = > dev_priv =3D kzalloc(sizeof(*dev_priv), GFP_KERNEL); > if (dev_priv =3D=3D NULL) > -- = > 1.7.10.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC