From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: make backlight functions take a
 connector v4
Date: Fri, 11 Oct 2013 15:44:05 -0700
Message-ID: <20131011154405.645eb07a@jbarnes-desktop>
References: <1381516314-6007-1-git-send-email-jbarnes@virtuousgeek.org>
	<1381527996-2567-1-git-send-email-jbarnes@virtuousgeek.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy7-pub.mail.unifiedlayer.com
	(oproxy7-pub.mail.unifiedlayer.com [67.222.55.9])
	by gabe.freedesktop.org (Postfix) with SMTP id 16712E844B
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 11 Oct 2013 15:44:01 -0700 (PDT)
Received: from [67.161.37.189] (port=59412 helo=jbarnes-desktop)
	by box514.bluehost.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128)
	(Exim 4.80) (envelope-from <jbarnes@virtuousgeek.org>)
	id 1VUlRA-0002gl-CG
	for intel-gfx@lists.freedesktop.org; Fri, 11 Oct 2013 16:44:00 -0600
In-Reply-To: <1381527996-2567-1-git-send-email-jbarnes@virtuousgeek.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 11 Oct 2013 14:46:36 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> On VLV/BYT, backlight controls a per-pipe, so when adjusting the
> backlight we need to pass the correct info.  So make the externally
> visible backlight functions take a connector argument, which can be used
> internally to figure out the pipe backlight to adjust.
> 
> v2: make connector pipe lookup check for NULL crtc (Jani)
>     fixup connector check in ASLE code (Jani)
> v3: make sure we take the mode config lock around lookups (Daniel)
> v4: fix double unlock in panel_get_brightness (Daniel)

Ok ok you caught me.  I didn't test v3...  I did test this version but
w/o lockdep and apparently w/o any ASLE events or I would have seen the
sleeping while atomic messages.

Guess we'll have to factor out the ASLE callback into a work queue (I
don't *think* the BIOS will care, we'll have to see).

-- 
Jesse Barnes, Intel Open Source Technology Center