From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH] drm: add support for additional stereo 3D modes Date: Fri, 11 Oct 2013 16:59:09 +0100 Message-ID: <20131011155909.GA30397@strange.amr.corp.intel.com> References: <1381411155-2841-1-git-send-email-thomas.wood@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1381411155-2841-1-git-send-email-thomas.wood@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Thomas Wood Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote: > + if ((multi_present == 1 || multi_present == 2) && You could use the awesome binary literals gcc extension here and 0b01 and 0b10 to be even closer to the spec wording. There's a precedent in drivers/watchdog/sunxi_wdt.c! -- Damien