From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 1/2] drm/i915: make backlight functions take
 a connector v3
Date: Fri, 11 Oct 2013 16:19:24 -0700
Message-ID: <20131011161924.2f82d6cb@jbarnes-desktop>
References: <1381516314-6007-1-git-send-email-jbarnes@virtuousgeek.org>
	<20131011213110.GJ8303@phenom.ffwll.local>
	<20131011143435.609795d3@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from outbound-ss-869.bluehost.com (outbound-ss-869.bluehost.com
	[69.89.24.83])
	by gabe.freedesktop.org (Postfix) with SMTP id 1E8B6E6E2F
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 11 Oct 2013 16:19:20 -0700 (PDT)
In-Reply-To: <20131011143435.609795d3@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 11 Oct 2013 14:34:35 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> > Ideas:
> > - Make sure all lvds/edp connectors are enabled and bash on all backlight
> >   interfaces (with igt_fork it's easy to do that concurrently).
> > - Race the above with output changes: dpms on/off and changing the crtc
> >   around.
> > - Race the above with system suspend for bonus points (can be completely
> >   stitched together from igt helpers).  
> 
> Sorry can't volunteer for that now, but those sound like good tests to
> write.

To clarify per our discussion on IRC.  I'll try to make some time next
week to add some tests for this.  We'll need them for the further
intel_panel.c work (getting rid of all the bogus save/restore of the
bits sprinkled about now that we don't do display reset).

But I don't want this fix (once I fix the locking) blocked on
those tests, since they'll probably take me a few days and people are
already using the original version, which is missing the locks for the
backlight class and ASLE call sites.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center