Re: [PATCH] drm/i915: increase the SWSCI DSLP default timeout to 50ms

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, Oct 11, 2013 at 05:29:17PM -0300, Paulo Zanoni wrote:
> 2013/10/10 Jani Nikula <jani.nikula@intel.com>:
> > On Wed, 09 Oct 2013, Paulo Zanoni <przanoni@gmail.com> wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> The spec says the default timeout should be 2ms, but on my machine
> >> this doesn't seem to be enough. Sometimes it works, sometimes I get
> >> these messages when booting:
> >>   - SWSCI request timed out
> >
> > BTW if this happens, and BIOS missed our call, will anyone clear
> > SWSCI_SCIC_INDICATOR? If not, we're bound to keep hitting:
> >
> >>   - SWSCI request already in progress
> >
> > So maybe we should just clear SWSCI_SCIC_INDICATOR ourselves on timeout?
> > Would that help?
> >
> 
> We definitely should do something in case we get a timeout. I don't
> really know the best solution here, I need to study the problem. I
> just tried to solve the immediate problem of "make my machine work" :)
> I also think we should be careful to not mess with someone else's operation.
> 
> Also, I think this problem is kinda "orthogonal" to increasing the
> timeout (although increasing the timeout hides it, hopefully forever).
> I added this to my TODO list, but I don't guarantee I will fix it in
> the next weeks.
> 
> 
> > In any case, this patch is
> >
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> 
> 
> Thanks for the review :)

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch