From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: increase the SWSCI DSLP default
 timeout to 50ms
Date: Fri, 11 Oct 2013 23:21:24 +0200
Message-ID: <20131011212124.GG8303@phenom.ffwll.local>
References: <1381347597-1505-1-git-send-email-przanoni@gmail.com>
	<87bo2x69ws.fsf@intel.com>
	<CA+gsUGRyFXCd=NiMB6Gau9dC3M0p3gC7XgPc-io3xZz7juzmxw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41])
	by gabe.freedesktop.org (Postfix) with ESMTP id B7EB7E62D7
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 11 Oct 2013 14:21:04 -0700 (PDT)
Received: by mail-ee0-f41.google.com with SMTP id d17so2175718eek.0
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 11 Oct 2013 14:21:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGRyFXCd=NiMB6Gau9dC3M0p3gC7XgPc-io3xZz7juzmxw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Oct 11, 2013 at 05:29:17PM -0300, Paulo Zanoni wrote:
> 2013/10/10 Jani Nikula <jani.nikula@intel.com>:
> > On Wed, 09 Oct 2013, Paulo Zanoni <przanoni@gmail.com> wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> The spec says the default timeout should be 2ms, but on my machine
> >> this doesn't seem to be enough. Sometimes it works, sometimes I get
> >> these messages when booting:
> >>   - SWSCI request timed out
> >
> > BTW if this happens, and BIOS missed our call, will anyone clear
> > SWSCI_SCIC_INDICATOR? If not, we're bound to keep hitting:
> >
> >>   - SWSCI request already in progress
> >
> > So maybe we should just clear SWSCI_SCIC_INDICATOR ourselves on timeout?
> > Would that help?
> >
> 
> We definitely should do something in case we get a timeout. I don't
> really know the best solution here, I need to study the problem. I
> just tried to solve the immediate problem of "make my machine work" :)
> I also think we should be careful to not mess with someone else's operation.
> 
> Also, I think this problem is kinda "orthogonal" to increasing the
> timeout (although increasing the timeout hides it, hopefully forever).
> I added this to my TODO list, but I don't guarantee I will fix it in
> the next weeks.
> 
> 
> > In any case, this patch is
> >
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> 
> 
> Thanks for the review :)

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch