From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available. Date: Fri, 11 Oct 2013 23:24:09 +0200 Message-ID: <20131011212409.GI8303@phenom.ffwll.local> References: <1381463805-10521-1-git-send-email-mattst88@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CFEDE64F1 for ; Fri, 11 Oct 2013 14:23:49 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id b47so2170423eek.3 for ; Fri, 11 Oct 2013 14:23:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Matt Turner Cc: Intel GFX , Ben Widawsky , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, Oct 11, 2013 at 12:51:34PM -0700, Matt Turner wrote: > On Fri, Oct 11, 2013 at 12:40 AM, Daniel Vetter wrote: > > On Fri, Oct 11, 2013 at 5:56 AM, Matt Turner wrote: > >> We were seriously *requiring* libdrm_nouveau unless explicitly disabled? > > > > I've had a bit of hilarious fail with optional testcases that > > automatically get disabled when depencies aren't around. Hence why > > they're all required by default with the optional switch to disable > > them. > > You've had this problem in general, or with nouveau? In general. > I mean, this is kind of how autotools is supposed to work. If you > explicitly want to ensure something is built you add --enable-thing. Yeah, but otoh I'm positively incompetent ;-) And since the main use case for i-g-t is to distribute the tests autoconf doesn't quite work like it usually does. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch