From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set Date: Mon, 14 Oct 2013 10:03:17 +0200 Message-ID: <20131014080317.GP8303@phenom.ffwll.local> References: <1381665391-20083-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com [209.85.215.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 19779E5C80 for ; Mon, 14 Oct 2013 01:02:58 -0700 (PDT) Received: by mail-ea0-f181.google.com with SMTP id d10so3119340eaj.26 for ; Mon, 14 Oct 2013 01:02:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1381665391-20083-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Oct 13, 2013 at 12:56:31PM +0100, Chris Wilson wrote: > At the moment we have 3 paths that lead to actually_set_backlight(), > from modesetting, ACPI/OpRegion requests and our very own > intel_backlight interface, and we have no way of distinguishing them in > the debug log. So add a debug breadcrumb to explain the source of the > backlight changes. > > Signed-off-by: Chris Wilson Yeah, we seem to have a bunch of bugs where the backlight somehow gets smashed to 0 and we don't know why. Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch