From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Use vlv_clock() in vlv_crtc_clock_get() Date: Mon, 14 Oct 2013 16:59:53 +0200 Message-ID: <20131014145953.GQ8303@phenom.ffwll.local> References: <1381751431-29424-1-git-send-email-ville.syrjala@linux.intel.com> <1381751431-29424-2-git-send-email-ville.syrjala@linux.intel.com> <20131014074416.0dc840c4@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46]) by gabe.freedesktop.org (Postfix) with ESMTP id F2984E6F92 for ; Mon, 14 Oct 2013 07:59:32 -0700 (PDT) Received: by mail-ee0-f46.google.com with SMTP id c13so3425575eek.19 for ; Mon, 14 Oct 2013 07:59:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20131014074416.0dc840c4@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Oct 14, 2013 at 07:44:16AM -0700, Jesse Barnes wrote: > On Mon, 14 Oct 2013 14:50:31 +0300 > ville.syrjala@linux.intel.com wrote: > = > > From: Ville Syrj=E4l=E4 > > = > > Avoid some code duplication. > > = > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/i915/intel_display.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > = > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i91= 5/intel_display.c > > index baa6ef6..b334c50 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -5211,10 +5211,10 @@ static void vlv_crtc_clock_get(struct intel_crt= c *crtc, > > clock.p1 =3D (mdiv >> DPIO_P1_SHIFT) & 7; > > clock.p2 =3D (mdiv >> DPIO_P2_SHIFT) & 0x1f; > > = > > - clock.vco =3D refclk * clock.m1 * clock.m2 / clock.n; > > - clock.dot =3D 2 * clock.vco / (clock.p1 * clock.p2); > > + vlv_clock(refclk, &clock); > > = > > - pipe_config->port_clock =3D clock.dot / 10; > > + /* clock.dot is the fast clock */ > > + pipe_config->port_clock =3D clock.dot / 5; > > } > > = > > static bool i9xx_get_pipe_config(struct intel_crtc *crtc, > = > Looks like this will result in the same bits. > = > Reviewed-by: Jesse Barnes Both merged, thanks for patches&review. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch