From: Daniel Vetter <daniel@ffwll.ch>
To: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: intel-gfx@lists.freedesktop.org,
Mario Kleiner <mario.kleiner@tuebingen.mpg.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/3] drm/i915: Fix scanoutpos calculations
Date: Mon, 14 Oct 2013 17:13:10 +0200 [thread overview]
Message-ID: <20131014151310.GR8303@phenom.ffwll.local> (raw)
In-Reply-To: <CAEsyxyhB_5nMgkU-7CgX4jpdkMiHYEv4RfxpffKf4ndt+W0FdQ@mail.gmail.com>
On Sat, Oct 12, 2013 at 01:22:40AM +0200, Mario Kleiner wrote:
> Yes.
> On Oct 12, 2013 1:18 AM, "Daniel Vetter" <daniel@ffwll.ch> wrote:
> >
> > On Fri, Oct 11, 2013 at 04:31:38PM +0200, Mario Kleiner wrote:
> > > Daniel, Ville,
> > >
> > > i tested Ville's patch series for the scanoutpos improvements on a
> > > GMA-950, on top of airlied's current drm-next branch.
> > >
> > > There's one issue: The variable "position" in
> > > i915_get_crtc_scanoutpos() must be turned from a u32 into a int,
> > > otherwise funny sign errors happen and we end up with *vpos being
> > > off by multiple million scanlines and timestamps being off by over
> > > 60 seconds.
> > >
> > > Other than that looks good. Execution time is now better:
> > >
> > > Before uncore.lock addition: 3-4 usecs execution time for the
> > > scanoutpos query on my machine. After uncore.lock addition
> > > (3.12.0-rc3) 9-20 usecs, sometimes repetition of the timing loop
> > > triggered. After Ville's patches down to typically 3-8 usecs,
> > > occassionally spiking to almost 20 usecs.
> > >
> > > I'll make my patches for the realtime kernel + increased accuracy on
> > > top of drm-next + Ville's patches.
> >
> > So official reviewed-by/tested-by from you on Ville's latest patches in
> > this thread?
>
> Yes.
Ok, slurped in the entire series, thanks for the review and testing.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-10-14 15:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 10:02 [PATCH 0/3] drm/i915: i915_get_crtc_scanoutpos improvements ville.syrjala
2013-09-23 10:02 ` [PATCH 1/3] drm/i915: Skip register reads in i915_get_crtc_scanoutpos() ville.syrjala
2013-09-23 10:30 ` Chris Wilson
2013-09-23 11:48 ` [PATCH v2 " ville.syrjala
2013-09-24 9:11 ` Daniel Vetter
2013-09-25 4:45 ` Mario Kleiner
2013-09-25 7:52 ` Daniel Vetter
2013-09-25 2:35 ` Mario Kleiner
2013-09-25 8:14 ` Ville Syrjälä
2013-09-26 16:12 ` Mario Kleiner
2013-09-23 10:02 ` [PATCH 2/3] drm/i915: Fix scanoutpos calculations ville.syrjala
2013-09-25 2:39 ` Mario Kleiner
2013-10-11 14:31 ` Mario Kleiner
2013-10-11 16:10 ` [PATCH v2 " ville.syrjala
2013-10-11 23:19 ` [PATCH " Daniel Vetter
2013-10-11 23:22 ` Mario Kleiner
2013-10-14 15:13 ` Daniel Vetter [this message]
2013-09-23 10:02 ` [PATCH 3/3] drm/i915: Improve the accuracy of get_scanout_pos on CTG+ ville.syrjala
2013-09-25 3:12 ` Mario Kleiner
2013-09-25 8:11 ` Ville Syrjälä
2013-09-25 8:46 ` Daniel Vetter
2013-09-26 17:04 ` Mario Kleiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014151310.GR8303@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mario.kleiner.de@gmail.com \
--cc=mario.kleiner@tuebingen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox