From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/2] drm/i915: Gen2 vblank stuff
Date: Mon, 14 Oct 2013 17:23:21 +0200 [thread overview]
Message-ID: <20131014152321.GS8303@phenom.ffwll.local> (raw)
In-Reply-To: <20131014100111.GA29463@nuc-i3427.alporthouse.com>
On Mon, Oct 14, 2013 at 11:01:11AM +0100, Chris Wilson wrote:
> On Fri, Oct 11, 2013 at 09:52:42PM +0300, ville.syrjala@linux.intel.com wrote:
> > Continuing a bit with improving the vblank timestamp stuff, I decided that
> > it's also time to fix gen2 properly.
> >
> > All this time we've been pretending it has the same pixel+frame counter that
> > gen3 and gen4 have, when in fact it doesn't. Luckily the same offset has
> > nothing else on gen2, so it has just read out as 0 and everything more or
> > less worked.
> >
> > Sadly there doesn't seem to be any frame counter register on gen2. For the
> > scanout position, DSL + additional tricks works equally well for gen2 as
> > it does for ctg+.
>
> Confirmed the absence of said registers, so
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Both merged, thanks for patches&review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-10-14 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 18:52 [PATCH 0/2] drm/i915: Gen2 vblank stuff ville.syrjala
2013-10-11 18:52 ` [PATCH 1/2] drm/i915: Fix gen2 scanout position readout ville.syrjala
2013-11-06 12:38 ` Rodrigo Vivi
2013-11-06 13:05 ` Ville Syrjälä
2013-10-11 18:52 ` [PATCH 2/2] drm/i915: Don't pretend that gen2 has a hardware frame counter ville.syrjala
2013-10-14 10:01 ` [PATCH 0/2] drm/i915: Gen2 vblank stuff Chris Wilson
2013-10-14 15:23 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014152321.GS8303@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox