From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 0/2] drm/i915: Gen2 vblank stuff Date: Mon, 14 Oct 2013 17:23:21 +0200 Message-ID: <20131014152321.GS8303@phenom.ffwll.local> References: <1381517564-6378-1-git-send-email-ville.syrjala@linux.intel.com> <20131014100111.GA29463@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f178.google.com (mail-ea0-f178.google.com [209.85.215.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 99556E70D7 for ; Mon, 14 Oct 2013 08:23:00 -0700 (PDT) Received: by mail-ea0-f178.google.com with SMTP id a15so3473743eae.37 for ; Mon, 14 Oct 2013 08:22:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20131014100111.GA29463@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Oct 14, 2013 at 11:01:11AM +0100, Chris Wilson wrote: > On Fri, Oct 11, 2013 at 09:52:42PM +0300, ville.syrjala@linux.intel.com wrote: > > Continuing a bit with improving the vblank timestamp stuff, I decided that > > it's also time to fix gen2 properly. > > > > All this time we've been pretending it has the same pixel+frame counter that > > gen3 and gen4 have, when in fact it doesn't. Luckily the same offset has > > nothing else on gen2, so it has just read out as 0 and everything more or > > less worked. > > > > Sadly there doesn't seem to be any frame counter register on gen2. For the > > scanout position, DSL + additional tricks works equally well for gen2 as > > it does for ctg+. > > Confirmed the absence of said registers, so > Reviewed-by: Chris Wilson Both merged, thanks for patches&review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch