From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Use pipe_name() instead of the pipe number Date: Tue, 15 Oct 2013 20:59:17 +0300 Message-ID: <20131015175917.GQ13047@intel.com> References: <1381844743-28488-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 3323DE74A4 for ; Tue, 15 Oct 2013 10:59:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1381844743-28488-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Oct 15, 2013 at 02:45:43PM +0100, Damien Lespiau wrote: > Yet another direct usage of the pipe number instead of pipe_name(). > We've been tracking them lately but managed to miss this one. > = > Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrj=E4l=E4 I actually see two more in intel_dsi.c and intel_panel.c. > --- > drivers/gpu/drm/i915/intel_display.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index b9cede7..81f7fa5 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -10734,11 +10734,11 @@ static void intel_modeset_readout_hw_state(stru= ct drm_device *dev) > } > = > encoder->connectors_active =3D false; > - DRM_DEBUG_KMS("[ENCODER:%d:%s] hw state readout: %s, pipe=3D%i\n", > + DRM_DEBUG_KMS("[ENCODER:%d:%s] hw state readout: %s, pipe %c\n", > encoder->base.base.id, > drm_get_encoder_name(&encoder->base), > encoder->base.crtc ? "enabled" : "disabled", > - pipe); > + pipe_name(pipe)); > } > = > list_for_each_entry(connector, &dev->mode_config.connector_list, > -- = > 1.8.3.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC