From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3] drm: add support for additional stereo 3D modes Date: Wed, 16 Oct 2013 19:48:33 +0200 Message-ID: <20131016174833.GO4830@phenom.ffwll.local> References: <20131015175554.GP13047@intel.com> <1381935530-6393-1-git-send-email-thomas.wood@intel.com> <20131016150729.GC13047@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com [209.85.215.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F4D1E7591 for ; Wed, 16 Oct 2013 10:48:12 -0700 (PDT) Received: by mail-ea0-f181.google.com with SMTP id d10so545905eaj.12 for ; Wed, 16 Oct 2013 10:48:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20131016150729.GC13047@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Thomas Wood , dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 16, 2013 at 06:07:30PM +0300, Ville Syrj=E4l=E4 wrote: > On Wed, Oct 16, 2013 at 03:58:50PM +0100, Thomas Wood wrote: > > Parse the 3D_Structure_ALL and 3D_MASK fields of the HDMI Vendor > > Specific Data Block to expose more stereo 3D modes. > > = > > v2: Use (1 << 0) for consistency. (Ville Syrj=E4l=E4) > > Skip adding any modes if 3D_MASK is indicated as being present but > > the length only includes 3D_Structure_ALL. (Ville Syrj=E4l=E4) > > Check that the value of HDMI_3D_LEN is large enough to include > > 3D_Structure_ALL and 3D_MASK, if they are present. (Ville Syrj=E4l= =E4) > > v3: Increment offset before the length checks. (Ville Syrj=E4l=E4) > > = > > Signed-off-by: Thomas Wood > = > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch