From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: vlv: fix VGA hotplug after modeset Date: Wed, 16 Oct 2013 22:03:12 +0200 Message-ID: <20131016200311.GP4830@phenom.ffwll.local> References: <1381945164-22093-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com [209.85.215.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C4EEE77E3 for ; Wed, 16 Oct 2013 13:02:52 -0700 (PDT) Received: by mail-ea0-f182.google.com with SMTP id o10so620227eaj.27 for ; Wed, 16 Oct 2013 13:02:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1381945164-22093-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 16, 2013 at 08:39:24PM +0300, Imre Deak wrote: > Since > > commit 912d812e84cea8689a2bf3dd13b11dfe191f0f1e > Author: Daniel Vetter > Date: Thu Oct 11 20:08:23 2012 +0200 > > drm/i915/crt: don't set HOTPLUG bits on !PCH > > on VLV we don't detect any VGA unplug event after a modeset, since there we > reset the ADPA hotplug bits. Fix it by preserving the hotplug bits on VLV as > well. > > Signed-off-by: Imre Deak Queued for -next (with a bikeshed to make it consistent with Chris' equivalent fix in intel_crt_reset), thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_crt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c > index becb311..bd37685 100644 > --- a/drivers/gpu/drm/i915/intel_crt.c > +++ b/drivers/gpu/drm/i915/intel_crt.c > @@ -274,7 +274,7 @@ static void intel_crt_mode_set(struct intel_encoder *encoder) > struct drm_display_mode *adjusted_mode = &crtc->config.adjusted_mode; > u32 adpa; > > - if (HAS_PCH_SPLIT(dev)) > + if (HAS_PCH_SPLIT(dev) || IS_VALLEYVIEW(dev)) > adpa = ADPA_HOTPLUG_BITS; > else > adpa = 0; > -- > 1.8.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch