From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Print RC6 info less often
Date: Mon, 21 Oct 2013 10:05:09 +0200
Message-ID: <20131021080508.GE4830@phenom.ffwll.local>
References: <1382124727-12255-1-git-send-email-benjamin.widawsky@intel.com>
	<20131019115312.GB23391@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f178.google.com (mail-ea0-f178.google.com
	[209.85.215.178])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1F060E662E
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 21 Oct 2013 01:04:47 -0700 (PDT)
Received: by mail-ea0-f178.google.com with SMTP id a15so3225278eae.23
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 21 Oct 2013 01:04:47 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20131019115312.GB23391@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Ben Widawsky <benjamin.widawsky@intel.com>, Intel GFX <intel-gfx@lists.freedesktop.org>, Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Oct 19, 2013 at 12:53:12PM +0100, Chris Wilson wrote:
> On Fri, Oct 18, 2013 at 12:32:07PM -0700, Ben Widawsky wrote:
> > Since we use intel_enable_rc6() now for more than just when we're
> > enabling RC6, we'll see this message many times, and it is just
> > confusing.
> 
> I agree. Ok, had to double check that i915.i915_enable_rc6 was not
> writable at runtime, so it looks like the defaults are fixed and so it
> is not possible for intel_enable_rc6() to return different values over
> its lifetime.
>  
> > As an example, calc_residency calls this function whenever poked via
> > sysfs. This leaves the impression in dmesg that we're constantly
> > re-enabling RC6.
> > 
> > While at it, move the defines and description from drv.h to intel_pm.c,
> > since these are only ever used in that code.
> > 
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch