Re: [PATCH 07/16] drm/i915: crc support for hsw

Daniel Vetter
2013-10-17T13:06:21Z

On Thu, Oct 17, 2013 at 11:53:49AM +0100, Damien Lespiau wrote:
> On Wed, Oct 16, 2013 at 10:55:52PM +0200, Daniel Vetter wrote:
> > hw designers decided to change the CRC registers and coalesce them all
> > into one. Otherwise nothing changed. I've opted for a new hsw_ version
> > to grab the crc sample since hsw+1 will have the same crc registers,
> > but different interrupt source registers. So this little helper
> > function will come handy there.
> >
> > Also refactor the display error handler with a neat pipe loop.
> >
> > v2: Use for_each_pipe.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Patches 1-7 are:
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

Thanks for the review, I've merged the patches thus far.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch