From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 00/16] CRC support for non-ivb Date: Mon, 21 Oct 2013 15:08:58 +0300 Message-ID: <20131021120857.GW13047@intel.com> References: <1381956961-16875-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 46B0CE6A66 for ; Mon, 21 Oct 2013 05:09:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1381956961-16875-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 16, 2013 at 10:55:45PM +0200, Daniel Vetter wrote: > Hi all, > = > I've stitched together basic CRC support for non-ivb platforms. Still nee= d to do > a bit more testing on this, but ignoring bugs this should be it. We also = need to > pimp the igt testcase a bit so that it falls back to the new PIPE source = if the > PLANE1 source isn't available. > = > Review and comments highly welcome. Apart from the three minor things I commented on, I couldn't find any real problems with the series. So the remainder of the series is: Reviewed-by: Ville Syrj=E4l=E4 > = > Cheers, Daniel > = > Daniel Vetter (16): > drm/i915: extract display_pipe_crc_update > drm/i915: add CRC #defines for ilk/snb > drm/i915: wire up CRC interrupt for ilk/snb > drm/i915: use ->get_vblank_counter for the crc frame counter > drm/i915: wait one vblank when disabling CRCs > drm/i915: fix CRC debugfs setup > drm/i915: crc support for hsw > drm/i915: Adjust CRC capture for pre-gen5/vlv > drm/i915: CRC source selection #defines for gmch/vlv chips > drm/i915: Wire up CRC interrupts for pre-gen5/vlv > drm/i915: Enable CRC interrupts on pre-gen5/vlv > drm/i915: Fix PIPE_CRC_CTL for vlv > drm/i915: Add new CRC sources > drm/i915: Wire up CRC support for gen3/4 > drm/i915: Wire up gen2 CRC support > drm/i915: Wire up CRC for vlv > = > drivers/gpu/drm/i915/i915_debugfs.c | 164 ++++++++++++++++++++++++++++++= +----- > drivers/gpu/drm/i915/i915_drv.h | 6 ++ > drivers/gpu/drm/i915/i915_irq.c | 151 +++++++++++++++++++++++++-----= --- > drivers/gpu/drm/i915/i915_reg.h | 74 +++++++++++++--- > 4 files changed, 328 insertions(+), 67 deletions(-) > = > -- = > 1.8.4.rc3 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC