From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 1/2] drm/i915: Abstract backlight registers a bit Date: Mon, 21 Oct 2013 15:48:16 -0700 Message-ID: <20131021224816.GG755@bwidawsk.net> References: <1382376938-29933-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id D9904E6D6E for ; Mon, 21 Oct 2013 15:48:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, Oct 22, 2013 at 12:30:11AM +0200, Daniel Vetter wrote: > On Mon, Oct 21, 2013 at 7:35 PM, Ben Widawsky > wrote: > > Many GENs generally perform the same actions just on different > > registers. This is true going forward as well. To ease the transition a > > bit, extract the common code where possible. > > > > Signed-off-by: Ben Widawsky > > Imo we should just switch to vtables or something like that, since > it's not just the register that changes, but also the meaning of the > different bits in the registers themselves and the logic to drive > stuff. We've often had regression-galore in this code and strictly > separating different platforms should help. I hope. > -Daniel I do not disagree. I have neither the skill, time, not inclination to do that properly, and I really only care about patch 2. The cleanup here makes the next patch slightly nicer, but I can live with whatever. -- Ben Widawsky, Intel Open Source Technology Center