From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/4] drm/i915: Remove
 WaFbcDisableDpfcClockGating on HSW
Date: Mon, 28 Oct 2013 17:12:08 +0100
Message-ID: <20131028161208.GQ18189@phenom.ffwll.local>
References: <1382633954-7375-1-git-send-email-benjamin.widawsky@intel.com>
	<1382633954-7375-2-git-send-email-benjamin.widawsky@intel.com>
	<CA+gsUGSfEe9MvTawAoy4ehLQDeaWSxNzqK2GvzN3vXJYQcNmYg@mail.gmail.com>
	<20131027134455.GF18189@phenom.ffwll.local>
	<CA+gsUGThHv7QByr3jQ6urFFAxerSRhq0pvZk3um9GqGgFL4AwA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41])
	by gabe.freedesktop.org (Postfix) with ESMTP id 36693E6783
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 28 Oct 2013 09:11:41 -0700 (PDT)
Received: by mail-ee0-f41.google.com with SMTP id e53so77930eek.28
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 28 Oct 2013 09:11:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGThHv7QByr3jQ6urFFAxerSRhq0pvZk3um9GqGgFL4AwA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, Art Runyan <arthur.j.runyan@intel.com>, Ben Widawsky <ben@bwidawsk.net>, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Oct 28, 2013 at 10:22:31AM -0200, Paulo Zanoni wrote:
> 2013/10/27 Daniel Vetter <daniel@ffwll.ch>:
> > On Fri, Oct 25, 2013 at 03:27:50PM -0200, Paulo Zanoni wrote:
> >> 2013/10/24 Ben Widawsky <benjamin.widawsky@intel.com>:
> >> > Production HSW does not need it. I confirmed this with Art.
> >> >
> >> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> >>
> >> I just hope these things don't start uncovering bugs :)
> >>
> >> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > Merged the first 2 patches of this series. Not sure what to do with the
> > other two, since fbc is essentially disabled on pre-hsw. And no one seems
> > to really work on it :( So I only see minimal reasons to frob with it ...
> 
> IMHO what you said is another reason to actually merge the other two
> patches, since they make FBC-only WAs be applied only on FBC (e.g.,
> probably never).

Oh, that was just a comment on top since the last 2 patches in this series
are blocked on review comments anyway. I'll pull them in once that's
settled. But maybe it spurs someone to work a bit on fbc ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch