From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v4] drm/i915: rename i915_init_power_well to init_power_domains_init Date: Tue, 29 Oct 2013 18:53:50 +0100 Message-ID: <20131029175350.GA17345@phenom.ffwll.local> References: <1382711810-25881-5-git-send-email-imre.deak@intel.com> <1382973635-11992-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 07EF5EE599 for ; Tue, 29 Oct 2013 10:53:30 -0700 (PDT) Received: by mail-ee0-f54.google.com with SMTP id t10so95531eei.41 for ; Tue, 29 Oct 2013 10:53:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Oct 28, 2013 at 04:51:52PM -0200, Paulo Zanoni wrote: > 2013/10/28 Imre Deak : > > Similarly rename the other related functions in the power domain > > interface. > > > > Higher level driver code calling these functions knows only about power > > domains, not the underlying power wells which may be different on > > different platforms. Also these functions really init/cleanup/resume > > power domains and only through that all related power wells, so rename > > them accordingly. > > > > Note that I left i915_{request,release}_power_well as is, since that > > really changes the state only of a single power well (and is HSW > > specific). It should also get a better name once we make it more > > generic by controlling things through a new audio power domain. > > > > v4: > > - use intel prefix instead of i915 everywhere (Paulo) > > - use a $prefix_$block_$action format (Daniel) > > Reviewed-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch